Improve bootstrap / initialization of the site:install method #5576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to use "createEarly".
…inherits ConfigAwareInterface from DrushCommands.
greg-1-anderson
force-pushed
the
si-bootstrap
branch
from
0f3cf01
to
3d8132e
Compare
weitzman
approved these changes
May 20, 2023
src/Application.php
Outdated
| @@ -327,8 +328,14 @@ public function configureAndRegisterCommands(InputInterface $input, OutputInterf | |||
| // unset($commandClasses[__DIR__ . '/Commands/help/HelpCommands.php']); | |||
| // unset($commandClasses[__DIR__ . '/Commands/help/ListCommands.php']); | |||
|
|
|||
| // Instantiate our command handler objects with the service manager | |||
| // (handles 'createEarly' static factories) | |||
| $commanInstances = $this->serviceManager->instantiateServices($commandClasses, Drush::getContainer()); | |||
There was a problem hiding this comment.
typo - missing d in commanInstances
Co-authored-by: Moshe Weitzman <weitzman@tejasa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll start by adding a
createEarlyfactory, and improve from there.