Prevent drush from crushing, when command extends non-existent class #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyano
force-pushed
the
fix-fatal-on-non-existent-class
branch
from
839e3c8
to
bae9873
Compare
|
We probably need some form of notification, even if it's only a debug log message, so that commands do not silently disappear when underlying things change in such a way as to prevent instantiation from working. |
ilyano
force-pushed
the
fix-fatal-on-non-existent-class
branch
from
bae9873
to
b668d23
Compare
|
@greg-1-anderson thanks for the notice! I've added debug message. |
ilyano
force-pushed
the
fix-fatal-on-non-existent-class
branch
from
b668d23
to
46efb84
Compare
|
This seems ok to me, but it needs to target the 13.x branch now. |
ilyano
force-pushed
the
fix-fatal-on-non-existent-class
branch
from
46efb84
to
3143bca
Compare
ilyano
force-pushed
the
fix-fatal-on-non-existent-class
branch
from
3143bca
to
b5019a1
Compare
|
@greg-1-anderson target branch has been updated, source branch has been rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5860