Fix wrong keyvalue store being used for the deploy hook registry

[DieterHolvoet]

Fixes #6081.

[weitzman]

LGTM, but what are the ramifications if a D10 site upgrades its Drush to 13, while staying on D10? Past deploy hooks will run?

[DieterHolvoet]

Yes, that's what happened to me.

[weitzman]

Sorry I was unclear. If this or goes in, it could negatively affect a site that is only upgrading their drush and not their Drupal.

[DieterHolvoet]

No that’s what I meant, I only updated Drush, not Drupal. This is obviously a mistake, no? It used to be deploy_hook, then it was mistakingly(?) changed to post_update, which is a different kind of update hook.

[weitzman]

Yes it's a mistake and you have the right fix. I'm just wondering if we should copy data into the new registry to avoid problems. Or something.

[DuaelFr]

I can confirm the issue (introduced in f9186d6) and the fix.
I believe it's a critical one as it can lead to data loss given the wide usage of deploy hooks.

The only problem I can see here is that this fix would land in a 13.0.x version and might cause issues to people that ran their deploy hooks with 13.0.0 for the first time. I believe we need an upgrade path for this specific use case.

[bircher]

Yes I think this should be changed as soon as possible.
It will not affect people upgrading drush from 12 to 13+fix, only for people going from 13-fix to 13+fix, but that is for sure a much smaller group.

[bircher]

I wrote more on slack, I will post it here too so that someone might find it.

We merge this and fix drush 13 and release a new version with it.
So drush 12 is ok, then some versions of drush 13 are broken, and then later versions of drush 13 are ok again.

• If you update from drush 12 to the fixed drush 13, all is good.
• if you update from drush 12 to a broken drush 13 then you risk running old hooks again, you notice and you don't run the deploy hooks and you update to the fixed drush 13 and you are fine.
• If you started with a a broken drush 13 or updated and didn't notice and you have run drush deploy with the broken drush 13 you can fix this in the following way:
  update to the fixed drush 13 without adding any new deploy hook in that deployment, then run:
  drush deploy:mark-complete.
  Now the correct key value store knows about the hooks that were run with the wrong key value store. And you are good too.