Use Class#subclasses for DescendantTracker #64
+52
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash-gordon
force-pushed
the
use-subclasess
branch
from
4b80f7f
to
5a015e9
Compare
solnic
reviewed
Jan 9, 2022
| @@ -18,6 +18,6 @@ class Grandchild < Child | |||
| end | |||
|
|
|||
| it "tracks descendants" do | |||
| expect(Test::Parent.descendants).to eql([Test::Grandchild, Test::Child]) | |||
| expect(Test::Parent.descendants).to eql([Test::Child, Test::Grandchild]) | |||
There was a problem hiding this comment.
yeah, it'll be. But I think it's fine since it's now consistent with subclasses and other implementations. Application-wise this shouldn't be a problem for all/almost all cases IMO. Nobody declared the order of the collection, it could be a set as well.
There was a problem hiding this comment.
we're still 0.x btw
There was a problem hiding this comment.
yeah I know, just pointing it out, as it's something worth mentioning in the changelog
flash-gordon
force-pushed
the
use-subclasess
branch
from
5a015e9
to
63976da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 3.1+ feature. I would expect this to work slower compared to the previous implementation, OTOH
.descendantsnormally called a limited number of times. Also, the new version doesn't hold hard references to classes which is good for code reloading.