Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Actions build matrix #4

Closed
wants to merge 3 commits into from
Closed

Added GitHub Actions build matrix #4

wants to merge 3 commits into from

Conversation

bkuhlmann
Copy link
Contributor

@bkuhlmann bkuhlmann commented Sep 29, 2023

Overview

Necessary to build on the team's supported Ruby versions.

Details

  • Resolves Issue Add build matrix #2.
  • Git Lint was removed since I don't support older versions of Ruby in order to keep my health and sanity in check. 😅 This could be still used as a separate action but doesn't sound like this will be welcome in the community.

After discussing with the team, it sounds like very few are willing to add this kind of rigor and quality to the project. There are so many benefits to having consistent commits especially when it comes to automatically generating release notes (including a solid Git Rebase workflow). Alas.
Necessary to support GitHub Actions build matrix since defining the version within the `Gemfile` causes builds failures on Ruby 3.1.0 and 3.0.0.
Necessary to build and test this gem all supported Ruby versions.
@timriley timriley closed this Oct 2, 2023
@waiting-for-dev waiting-for-dev deleted the ci_matrix branch October 3, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants