Skip to content

Commit

Permalink
fix(exception-handling): [eclipse-tractusx#841] remove todo
Browse files Browse the repository at this point in the history
  • Loading branch information
dsmf committed Aug 2, 2024
1 parent 147f701 commit d3c8af7
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,12 @@ private void createShellEndpointCouldNotBeRetrievedTombstone(
.withErrorDetail(exception.getMessage())
.withRootCauses(rootErrorMessages)
.build();
String endpointURL = null; // TODO (mfischer) test

String endpointURL = null;
if (exception instanceof ShellNotFoundException) {
endpointURL = String.join("; ", ((ShellNotFoundException) exception).getCalledEndpoints());
}

final Tombstone tombstone = Tombstone.builder()
.endpointURL(endpointURL)
.catenaXId(itemId.getGlobalAssetId())
Expand All @@ -123,7 +125,6 @@ private void createShellEndpointCouldNotBeRetrievedTombstone(
itemContainerBuilder.tombstone(tombstone);
}


private Tombstone createNoBpnProvidedTombstone(final JobParameter jobData,
final PartChainIdentificationKey itemId) {
log.warn("Could not process item with id {} because no BPN was provided. Creating Tombstone.",
Expand Down

0 comments on commit d3c8af7

Please sign in to comment.