Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSVs take up too much space #498

Closed
jesteria opened this issue Nov 7, 2018 · 2 comments
Closed

CSVs take up too much space #498

jesteria opened this issue Nov 7, 2018 · 2 comments
Assignees

Comments

@jesteria
Copy link
Member

jesteria commented Nov 7, 2018

HDF matrix data must be present on the local file system. However, as an experimenter, I might like to be able to specify an S3 file path, with the expectation that this data will be downloaded from and uploaded to S3 as necessary, on my behalf.

@thcrock thcrock self-assigned this Feb 28, 2019
@thcrock thcrock changed the title HDF matrix storage backed by S3 CSVs take up too much space Mar 1, 2019
@thcrock
Copy link
Contributor

thcrock commented Mar 1, 2019

After talking with @nanounanue we decided to repurpose this: CSVs should be compressed by default. The current situation makes us want to use HDFs all the time even when we won't gain anything from them. Compressing CSVs would make it work for more use cases and make HDF-S3 support unnecessary

@jesteria
Copy link
Member Author

jesteria commented Mar 5, 2019

👍 👍

I'm not positive that compressed CSV will make this 100% unnecessary, (but yeah certainly might!). Regardless, it shouldn't be a ton of work to read and write CSVs with GZIP compression, by default, and I absolutely agree that that should be done.

We're just talking about something like:

with gzip.open(filename) as fd:
    reader_or_writer = csv.reader_or_writer(fd)

…Which, with S3Fs for example, just becomes:

with s3.open('mybucket/my-file.csv.gz', 'rb') as fd_compressed:
    fd = gzip.GzipFile(fileobj=fd_compressed)
    …

(Simply taken from the S3Fs docs.)

thcrock added a commit that referenced this issue Mar 6, 2019
- Make the CSVMatrixStore use compression and rename files to csv.gz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants