Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohort generator should drop options besides query #504

Closed
thcrock opened this issue Nov 9, 2018 · 0 comments
Closed

Cohort generator should drop options besides query #504

thcrock opened this issue Nov 9, 2018 · 0 comments
Assignees
@thcrock

Comments

@thcrock
Copy link
Contributor

thcrock commented Nov 9, 2018

Nobody uses or wants to use the other options in the cohort generator besides 'query', and the presence of all the options makes #503 harder. So drop the options and flatten the inherited classes into one class
@thcrock thcrock self-assigned this Nov 9, 2018
saleiro added a commit that referenced this issue Nov 27, 2018
@saleiro
Merge pull request #505 from dssg/cohort_replace
c079a0b 
Refactoring: Remove cohort options besides query [Resolves #504]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thcrock thcrock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thcrock