Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip Prediction saving #559

Closed
thcrock opened this issue Dec 28, 2018 · 0 comments
Closed

Add option to skip Prediction saving #559

thcrock opened this issue Dec 28, 2018 · 0 comments
Assignees
@thcrock
Labels
performance

Comments

@thcrock
Copy link
Contributor

thcrock commented Dec 28, 2018

Despite the use of the COPY command, saving predictions to the database is one of the most lengthy phases of the Experiment. We should be able to skip it and still get evaluation metrics.
@thcrock thcrock self-assigned this Dec 28, 2018
thcrock added a commit that referenced this issue Dec 28, 2018
@thcrock
Skip Prediction Saving [Resolves #559]
678e9e7 
- Add Predictor.needs_predictions that checks whether or not all of the
needed predictions are in the database
- Skip prediction/evaluation if both prediction and evaluation needs are
met
- Expose save_predictions=False keyword argument in experiment and add
to CLI and running document
thcrock added a commit that referenced this issue Dec 28, 2018
@thcrock
Skip Prediction Saving [Resolves #559]
572dec8 
- Add Predictor.needs_predictions that checks whether or not all of the
needed predictions are in the database
- Skip prediction/evaluation if both prediction and evaluation needs are
met
- Expose save_predictions=False keyword argument in experiment and add
to CLI and running document
thcrock added a commit that referenced this issue Dec 28, 2018
@thcrock
Skip Prediction Saving [Resolves #559]
9bf0ed1 
- Add Predictor.needs_predictions that checks whether or not all of the
needed predictions are in the database
- Skip prediction/evaluation if both prediction and evaluation needs are
met
- Expose save_predictions=False keyword argument in experiment and add
to CLI and running document
ivanhigueram pushed a commit that referenced this issue Jan 16, 2019
Merge pull request #561 from dssg/skip_predictions
80f8f7c 
Skip Prediction Saving [Resolves #559]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thcrock thcrock

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thcrock