Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator should check for capital letters in table names #632

Closed
shaycrk opened this issue Mar 14, 2019 · 2 comments
Closed

Validator should check for capital letters in table names #632

shaycrk opened this issue Mar 14, 2019 · 2 comments

Comments

@shaycrk
Copy link
Contributor

shaycrk commented Mar 14, 2019

Capital letters in table names seems to cause problems with table names being referenced with or without quotes at different points in the code. The validator should check for capitals in the labels, cohort, subset, and feature aggregation prefixes.
@SLavado
Copy link

SLavado commented May 23, 2019

just ran into this again/rediscovered it!

@shaycrk shaycrk mentioned this issue May 24, 2019
Merged
thcrock added a commit that referenced this issue May 24, 2019
@thcrock
Merge pull request #701 from dssg/kit_caps_test
3638f49 
The pull request changes the functionality of the string_is_tablesafe validation primitive to only allow lowercase letters (or numbers, underscores) in strings it checks, as well as adding additional tests for feature aggregation prefixes and subset names, both of which will be used for table names.

As described in #632, uppercase letters in these experiment config values end up getting lowercased on table creation by referenced using their uppercase forms (with quotes) at various places in the code, causing postgres to return a "table does not exist" error.

This PR also removes a redundant/conflicting dev.txt requirement of different versions of black, keeping the newer version.
@thcrock
Copy link
Contributor

thcrock commented May 24, 2019

Closed by #701

@thcrock thcrock closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shaycrk @thcrock @SLavado