Associate Experiment with all models and matrices [Resolves #411] #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To aid in the lookup of relevant matrices and models to an experiment afterwards, we want to record whether or not that experiment *used* that matrix or model, regardless of whether or not it had to *build* it. We still want to record which experiment built the matrix or model. This was already being recorded in the models.experiment_hash column, which is renamed to built_by_experiment. The matrices table gains a similar column to mirror this functionality. Audition is among the use cases for this change, so the pre-audition query is updated to reflect this. - Create experiment_matrices and experiment_models tables - Rename models.experiment_hash to models.built_by_experiment to contain what is currently stored there but with a more specific name - Add matrices.built_by_experiment to mirror the models column. - Add utils to record these rows and trigger them from the Experiment experiment_models - Update preaudition query to look at experiment_models fixing - Add note on these new tables to Experiment Algorithm doc and Experiment Running doc - Update getcwd patch in audition tests to only exist where it needs to, fixing a local test failure where the getcwd was screwing up testing.postgresql
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=========================================
Coverage ? 82.76%
=========================================
Files ? 81
Lines ? 4643
Branches ? 0
=========================================
Hits ? 3843
Misses ? 800
Partials ? 0
Continue to review full report at Codecov.
|
tweddielin
reviewed
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid in the lookup of relevant matrices and models to an experiment
afterwards, we want to record whether or not that experiment used that
matrix or model, regardless of whether or not it had to build it.
We still want to record which experiment built the matrix or model. This
was already being recorded in the models.experiment_hash column, which
is renamed to built_by_experiment. The matrices table gains a similar
column to mirror this functionality.
Audition is among the use cases for this change, so the pre-audition query is
updated to reflect this.
what is currently stored there but with a more specific name
experiment_models
fixing
Experiment Running doc
fixing a local test failure where the getcwd was screwing up
testing.postgresql