Move example yaml configuration files into subdirectory #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesteria
changed the title
example/config/
|
This looks fine, I can wait until reviews from the requested reviewers @tweddielin and @nanounanue to merge though |
…ig/` there are a lot of files in the repository root. a lot of them (sort of) need to be there. but these example configuration files can be moved without hurting anything.
…ple experiment config"
jesteria
force-pushed
the
jsl/cleanup/example-yaml
branch
from
7f47950
to
db23367
Compare
|
(Rebased branch with updates from |
|
@tweddielin and/or @nanounanue – any objections? 🤔 |
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
=======================================
Coverage 82.57% 82.57%
=======================================
Files 81 81
Lines 4625 4625
=======================================
Hits 3819 3819
Misses 806 806Continue to review full report at Codecov.
|
|
I wrangled answers from both that this is fine. Merging |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of files in the repository root. A lot of them (sort of) need to be there.
But these example configuration files can be moved, under
example/config/, without hurting anything.