Fix db engine check in Experiment [Resolves #538] #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thcrock
commented
Dec 4, 2018
jesteria
reviewed
Dec 5, 2018
jesteria
reviewed
Dec 5, 2018
jesteria
reviewed
Dec 5, 2018
The experiment checks whether or not the passed-in engine is a base sqlalchemy engine, and converts it into the serializable triage engine if so. However, this check was broken. This PR fixes it to actually duck-type, as well as moves the check to the MultiCore so we can actually error out if the wrong engine is passed.
thcrock
force-pushed
the
serializable_engine_check
branch
from
8244f94
to
1445686
Compare
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 82.57% 82.59% +0.02%
==========================================
Files 81 81
Lines 4625 4625
==========================================
+ Hits 3819 3820 +1
+ Misses 806 805 -1
Continue to review full report at Codecov.
|
|
Made the changes from jesse's review. Since the assignee isn't here until the middle of next week, and I think I've addressed all the concerns that they brought up, and the bug this fixes is a rather onerous one for current users of Triage, I'm opting to just merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experiment checks whether or not the passed-in engine is a base sqlalchemy engine, and converts it into the serializable triage engine if so.
However, this check was broken. This PR fixes it to actually duck-type,
to see if the engine can be pickled to a memory file