Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix uuid to evaluations tables [Resolves #591] #593

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

thcrock
Copy link
Contributor

@thcrock thcrock commented Feb 5, 2019

  • Add matrix uuid column to both train and test evaluations table
    schemas,
    updating the factory as well and adding migration to create it
  • commit session in test util MockMatrixStore so the matrix actually
    shows up in the database
  • In ModelEvaluator, include matrix_uuid in evaluation data sent to
    database

- Add matrix uuid column to both train and test evaluations table
schemas,
updating the factory as well and adding migration to create it
- commit session in test util MockMatrixStore so the matrix actually
shows up in the database
- In ModelEvaluator, include matrix_uuid in evaluation data sent to
database
Copy link
Contributor

@nanounanue nanounanue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to name this column as test_matrix_uuid instead of just matrix_uuid

@thcrock
Copy link
Contributor Author

thcrock commented Feb 6, 2019

The problem is that the evaluator works on both the train and test evaluations tables. I added the column to both because I figured unless there's a good reason we should keep the schema of the two tables as similar as possible. matrix_uuid works no matter which table it is. Options:

  1. Actually neglect to add any matrix column to the train evaluations table (you could get it by joining to models)
  2. Add the column to both tables, but prepend train or test to the column name in each one
  3. Add the column to both tables, with a generic name that works for both.

What do you think?

@nanounanue
Copy link
Contributor

I think that, for the moment, option 3 is the best.

@nanounanue nanounanue merged commit f9e7017 into master Feb 6, 2019
@thcrock thcrock deleted the add_matrix_to_eval branch February 12, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants