Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Generation Rewrite (WIP) #608

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Commits on Feb 21, 2019

  1. Feature Generation Rewrite

    Introduces the 'FeatureBlock' as the main interface for Triage to create features, instead of directly interfacing with collate.
    
    - Add FeatureBlock abstract base class. The abstract methods are aimed
    at providing an easy, flexible interface for feature generators to
    implement. The concrete methods are aimed at building on those abstract
    methods to provide a slightly easier, higher-level interface for
    Experiments, et al to use.
    
    - Splits up the bloated architect.FeatureGenerator into a couple
    different places: the code that generates is now in SpacetimeAggregations in feature_block _generators, and the code that runs the generated queries now lives in concrete methods of the FeatureBlock base class.
    
    - ExperimentBase now passes on config to generate_feature_blocks and
    owns a collection of resulting FeatureBlocks, instead of a
    FeatureGenerator object.
    
    - Instead of a FeatureDictionaryCreator object, the FeatureDictionary
    class is introduced that knows how to build itself from a collection of
    FeatureBlocks. The Experiment holds references to these as before.
    
    - Continuing the trend of molding collate to more closely fit how Triage
    is using it and removing unneeded flexibility, the unused Aggregation base class is folded
    into the SpacetimeAggregation so the latter can directly inherit from
    FeatureBlock. This way we get to remove/condense many tests, and sunset
    the collate integration tests because the methods being tested no longer
    exist and are tested in either SpacetimeAggregation or FeatureBlock. In
    addition, many of the arguments within SpacetimeAggregation are changed
    to their FeatureBlock equivalents to more tightly fit as a FeatureBlock
    subclass. Some of the more generic helper methods within
    SpacetimeAggregation are moved to FeatureBlock as concrete methods
    
    - With feature data now residing at a new config key, the experiment's
    config version is bumped to v7.
    thcrock committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    680c83c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6bc3a29 View commit details
    Browse the repository at this point in the history
  3. Test for verbose task info

    thcrock committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    ca9207e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Configuration menu
    Copy the full SHA
    cf96a6c View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Configuration menu
    Copy the full SHA
    6bff2bc View commit details
    Browse the repository at this point in the history
  2. Changes from review

    thcrock committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    7e6fa3e View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Configuration menu
    Copy the full SHA
    9dd5933 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. from review

    thcrock committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    3a3c71f View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. WIP

    thcrock committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    5a14339 View commit details
    Browse the repository at this point in the history
  2. changes from review

    thcrock committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    935e673 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Configuration menu
    Copy the full SHA
    4ce5c6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65cb36a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Update feature mock

    thcrock committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    929a2e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Configuration menu
    Copy the full SHA
    0463836 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. WIP

    thcrock committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    8733fcb View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Configuration menu
    Copy the full SHA
    3e40ae0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf74822 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. More fixes

    thcrock committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    0fd781b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    daf088d View commit details
    Browse the repository at this point in the history
  3. Fix validation

    thcrock committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    4a84431 View commit details
    Browse the repository at this point in the history
  4. Fix validate call

    thcrock committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    b7c9426 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    403d0f5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a628bcd View commit details
    Browse the repository at this point in the history
  7. Update docs some more

    thcrock committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    a98fae4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    acb8c45 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. Configuration menu
    Copy the full SHA
    a9df94b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd1887c View commit details
    Browse the repository at this point in the history