-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Generation Rewrite (WIP) #608
Open
thcrock
wants to merge
27
commits into
master
Choose a base branch
from
notice_removed_features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 21, 2019
-
Introduces the 'FeatureBlock' as the main interface for Triage to create features, instead of directly interfacing with collate. - Add FeatureBlock abstract base class. The abstract methods are aimed at providing an easy, flexible interface for feature generators to implement. The concrete methods are aimed at building on those abstract methods to provide a slightly easier, higher-level interface for Experiments, et al to use. - Splits up the bloated architect.FeatureGenerator into a couple different places: the code that generates is now in SpacetimeAggregations in feature_block _generators, and the code that runs the generated queries now lives in concrete methods of the FeatureBlock base class. - ExperimentBase now passes on config to generate_feature_blocks and owns a collection of resulting FeatureBlocks, instead of a FeatureGenerator object. - Instead of a FeatureDictionaryCreator object, the FeatureDictionary class is introduced that knows how to build itself from a collection of FeatureBlocks. The Experiment holds references to these as before. - Continuing the trend of molding collate to more closely fit how Triage is using it and removing unneeded flexibility, the unused Aggregation base class is folded into the SpacetimeAggregation so the latter can directly inherit from FeatureBlock. This way we get to remove/condense many tests, and sunset the collate integration tests because the methods being tested no longer exist and are tested in either SpacetimeAggregation or FeatureBlock. In addition, many of the arguments within SpacetimeAggregation are changed to their FeatureBlock equivalents to more tightly fit as a FeatureBlock subclass. Some of the more generic helper methods within SpacetimeAggregation are moved to FeatureBlock as concrete methods - With feature data now residing at a new config key, the experiment's config version is bumped to v7.
Configuration menu - View commit details
-
Copy full SHA for 680c83c - Browse repository at this point
Copy the full SHA 680c83cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bc3a29 - Browse repository at this point
Copy the full SHA 6bc3a29View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca9207e - Browse repository at this point
Copy the full SHA ca9207eView commit details
Commits on Feb 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for cf96a6c - Browse repository at this point
Copy the full SHA cf96a6cView commit details
Commits on Feb 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6bff2bc - Browse repository at this point
Copy the full SHA 6bff2bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e6fa3e - Browse repository at this point
Copy the full SHA 7e6fa3eView commit details
Commits on Mar 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9dd5933 - Browse repository at this point
Copy the full SHA 9dd5933View commit details
Commits on Mar 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3a3c71f - Browse repository at this point
Copy the full SHA 3a3c71fView commit details
Commits on Mar 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5a14339 - Browse repository at this point
Copy the full SHA 5a14339View commit details -
Configuration menu - View commit details
-
Copy full SHA for 935e673 - Browse repository at this point
Copy the full SHA 935e673View commit details
Commits on Mar 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4ce5c6f - Browse repository at this point
Copy the full SHA 4ce5c6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65cb36a - Browse repository at this point
Copy the full SHA 65cb36aView commit details
Commits on Mar 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 929a2e9 - Browse repository at this point
Copy the full SHA 929a2e9View commit details
Commits on Mar 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0463836 - Browse repository at this point
Copy the full SHA 0463836View commit details
Commits on Mar 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8733fcb - Browse repository at this point
Copy the full SHA 8733fcbView commit details
Commits on Apr 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3e40ae0 - Browse repository at this point
Copy the full SHA 3e40ae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf74822 - Browse repository at this point
Copy the full SHA cf74822View commit details
Commits on Apr 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0fd781b - Browse repository at this point
Copy the full SHA 0fd781bView commit details -
Configuration menu - View commit details
-
Copy full SHA for daf088d - Browse repository at this point
Copy the full SHA daf088dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a84431 - Browse repository at this point
Copy the full SHA 4a84431View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7c9426 - Browse repository at this point
Copy the full SHA b7c9426View commit details -
Configuration menu - View commit details
-
Copy full SHA for 403d0f5 - Browse repository at this point
Copy the full SHA 403d0f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a628bcd - Browse repository at this point
Copy the full SHA a628bcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a98fae4 - Browse repository at this point
Copy the full SHA a98fae4View commit details -
Configuration menu - View commit details
-
Copy full SHA for acb8c45 - Browse repository at this point
Copy the full SHA acb8c45View commit details
Commits on May 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a9df94b - Browse repository at this point
Copy the full SHA a9df94bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd1887c - Browse repository at this point
Copy the full SHA fd1887cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.