Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config is a str, not a fd #610

Merged
merged 1 commit into from
Feb 24, 2019
Merged

config is a str, not a fd #610

merged 1 commit into from
Feb 24, 2019

Conversation

nanounanue
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 21, 2019 •
edited
Loading

Codecov Report

Merging #610 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files          89       89           
  Lines        5821     5821           
=======================================
  Hits         4028     4028           
  Misses       1793     1793
Impacted Files Coverage Δ
src/triage/cli.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ffbe1...c2878d9. Read the comment docs.

thcrock
thcrock approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@thcrock thcrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I created #612 because these kind of papercuts happen very often with the CLI

@nanounanue nanounanue merged commit 8dee41d into master Feb 24, 2019
@nanounanue nanounanue deleted the config-is-a-str-not-a-file branch February 24, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesteria jesteria jesteria approved these changes

@thcrock thcrock thcrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nanounanue @codecov-io @jesteria @thcrock