Fix cohort in unit tests, remove old code, squash some warnings #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Have unit test cohort look in the past not future [Resolves #606] - Move last usage of metta, 'generate_uuid', to the identical 'filename_friendly_hash' function in catwalk.utils, and remove metta module [Resolves #312] - Remove most of catwalk README that has been long been out of date. - Squash some warnings in HDF and RQ - Remove logging overrides in tests, pytest should do this
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 69.64% 70.28% +0.64%
==========================================
Files 91 87 -4
Lines 5979 5775 -204
==========================================
- Hits 4164 4059 -105
+ Misses 1815 1716 -99
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is by no means all of the cleanup we have to do but it's some low-hanging fruit.
'filename_friendly_hash' function in catwalk.utils, and remove metta
module [Resolves Remove code in metta module that is deprecated #312]