Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster train/test task generation #628

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Faster train/test task generation #628

merged 2 commits into from
Mar 12, 2019

Conversation

ecsalomon
Copy link
Contributor

Generating train/test tasks can take hours. One culprit may be slow IO
of the matrices, which are loaded to decide if the job should be
processed. This commit makes the train-tester generate all of the tasks
withoug checking the matrices and skips processing the tasks if the
matrices are no good.

Generating train/test tasks can take hours. One culprit may be slow IO
of the matrices, which are loaded to decide if the job should be
processed. This commit makes the train-tester generate all of the tasks
withoug checking the matrices and skips processing the tasks if the
matrices are no good.
@ecsalomon ecsalomon requested a review from thcrock March 6, 2019 21:59
@codecov-io
Copy link

Codecov Report

Merging #628 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          87       87           
  Lines        5775     5775           
=======================================
  Hits         4059     4059           
  Misses       1716     1716
Impacted Files Coverage Δ
src/triage/component/catwalk/__init__.py 90.62% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14429e...55acec4. Read the comment docs.

Copy link
Contributor

@thcrock thcrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ecsalomon ecsalomon marked this pull request as ready for review March 12, 2019 17:19
@thcrock thcrock merged commit 041f568 into master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants