Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports in example postmodeling notebook #646

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

shaycrk
Copy link
Contributor

@shaycrk shaycrk commented Mar 21, 2019

Import postmodeling utilities from installed triage rather than assuming notebook is being run in postmodeling code directory for example notebook.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   82.98%   82.98%           
=======================================
  Files          87       87           
  Lines        5754     5754           
=======================================
  Hits         4775     4775           
  Misses        979      979

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ceaf48...963462c. Read the comment docs.

@nanounanue
Copy link
Contributor

Already fixed in dirty 🦆, but I see you point

@jesteria
Copy link
Member

👍

@nanounanue
Copy link
Contributor

We should clean this namespace and import from __init__.py ...

@nanounanue nanounanue merged commit 0142c1d into master Mar 26, 2019
@nanounanue nanounanue deleted the kit_fix_postmodeling_imports branch March 26, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants