Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.7 [Resolves #683] #684

Merged
merged 5 commits into from
May 6, 2019
Merged

Support Python 3.7 [Resolves #683] #684

merged 5 commits into from
May 6, 2019

Conversation

thcrock
Copy link
Contributor

@thcrock thcrock commented May 6, 2019

To support Python 3.7, remove the HDFMatrixStore (CSVs are compressed now, we get no real use out of HDF) and remove the ancient pytables dependency. Also update many documents and tests to remove HDF references.

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1dc8a4a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #684   +/-   ##
=========================================
  Coverage          ?   82.19%           
=========================================
  Files             ?       93           
  Lines             ?     6272           
  Branches          ?        0           
=========================================
  Hits              ?     5155           
  Misses            ?     1117           
  Partials          ?        0
Impacted Files Coverage Δ
src/triage/component/catwalk/storage.py 93.28% <ø> (ø)
src/triage/component/architect/utils.py 41.02% <ø> (ø)
src/triage/cli.py 83.95% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc8a4a...7ec77d7. Read the comment docs.

@@ -304,7 +304,7 @@ We need to specify the temporal configuration too

```sh
# Remember to run this in bastion NOT in your laptop shell!
triage experiment --matrix-format hdf experiments/eis_01.yaml --profile
triage experiment experiments/eis_01.yaml --profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nanounanue nanounanue merged commit c2a7728 into master May 6, 2019
@nanounanue nanounanue deleted the remove_hdf branch May 6, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants