Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Audition Improvements #844

Merged
merged 8 commits into from
Apr 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/tests/audition_tests/test_preaudition.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,13 @@ class ImmediateEvalFactory(EvaluationFactory):
pre_aud = PreAudition(db_engine)

# Expect the number of model groups with label_1
assert len(pre_aud.get_model_groups_from_label("label_1")) == sum(
assert len(pre_aud.get_model_groups_from_label("label_1")['model_groups']) == sum(
[x["label_definition"] == "label_1" for x in model_configs]
)

# Expect no baseline model groups
assert len(pre_aud.get_model_groups_from_label("label_1")['baseline_model_groups']) == 0

# Expect the number of model groups with certain experiment_hash
experiment_hash = list(
pd.read_sql(
Expand All @@ -92,7 +95,7 @@ class ImmediateEvalFactory(EvaluationFactory):
con=db_engine,
)["experiment_hash"]
)[0]
assert len(pre_aud.get_model_groups_from_experiment(experiment_hash)) == 1
assert len(pre_aud.get_model_groups_from_experiment(experiment_hash)['model_groups']) == 1

# Expect the number of model groups for customs SQL
query = """
Expand Down
Loading