Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 864 py39 #865

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Issue 864 py39 #865

merged 5 commits into from
Dec 7, 2021

Conversation

thcrock
Copy link
Contributor

@thcrock thcrock commented Sep 14, 2021

Removes Python3.6 support and adds up to 3.9.
Changes needed:

  • numpy upgrade
  • Removes create_autospec function call from catwalk integration test; it appears that simply passing the class name to spec_set works now, and create_autospec used in conjunction with this now breaks it.

@shaycrk
Copy link
Contributor

shaycrk commented Sep 17, 2021

Thanks @thcrock -- one quick question here: does this remove support for python 3.6 in the sense that the changes here break compatibility with 3.6 or just in the sense that we won't run unit test using 3.6 so don't guarantee that it will continue to work?

@thcrock
Copy link
Contributor Author

thcrock commented Sep 17, 2021

@shaycrk this drops support for 3.6 as numpy has dropped support for it.

@shaycrk
Copy link
Contributor

shaycrk commented Sep 17, 2021

Ah, that's too bad (not a huge deal, I just happen to still be on 3.6 in some of my environments). The changes here themselves look good to me.

Do you think we should do a bigger version bump (at least minor rather than patch) in that case?

@shaycrk shaycrk merged commit 829a1b7 into master Dec 7, 2021
@shaycrk shaycrk deleted the issue_864_py39 branch December 7, 2021 16:25
@shaycrk shaycrk mentioned this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants