-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GOSPAMetric: Avoid unnecessary copies and inefficient masking #1059
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b1ecde5
GOSPA: Added timing test
marvonlar 473322e
GOSPAMetric: Prepack data as ndarray
marvonlar c68017f
GOSPAMetric: Pre-group GTs and tracks
marvonlar bcb3916
GOSPAMetric: Fixed formatting errors
marvonlar f82c6c3
GOSPAMetric: Added test with single timestep
marvonlar 8660155
GOSPAMetric: Added tests for occasionally tracks/gt
marvonlar a9987c4
GOSPAMetric: Handle occasionally no tracks/gt
marvonlar 632c455
GOSPAMetric: Added test for no tracks
marvonlar 76c60cf
GOSPAMetric: Handle no tracks
marvonlar 59bd95b
GOSPAMetric: Added test for no ground truths
marvonlar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was not part of my first patch, but came up as I added some tests to provide coverage of my original changes.
It seems reasonable that GOSPA should report tracks as false also in the case where there are 0 ground truth states, right?
I don't fully understand why we test for
self.alpha == 2
, but this is what is done everywhere else (see for instance line 369).