Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UncertaintyReward bug and improve ExpectedKLDivergence #1066

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

timothy-glover
Copy link
Contributor

This pull request addresses an issue when constructing GroundTruthState for generating detections in the UncertaintyReward class that was adversely affecting sensor management performance when using this reward. There are a number of reasons for these changes:

  1. Fix the issue where the detections dict would be populated with repeated detections of one track instead of each detectable track, causing the sensor manager to only focus on one track in sensor management for multiple tracks.
  2. Pass all tracks as GroundTruthState into sensor.measure such that sensor specific behaviours when detecting multiple targets can be maintained in sensor management.
  3. Create a mapping from GroundTruthState to predicted_track such that the prediction object can be passed to the updater rather than the GroundTruthState within detection.groundtruth_path.

Relevant parts of these changes have also been migrated to the ExpectedKLDivergence reward where appropriate, to allow sensor.measure to also operate on multiple tracks at once.

@timothy-glover timothy-glover requested a review from a team as a code owner July 19, 2024 14:10
@timothy-glover timothy-glover requested review from sdhiscocks and akenyon and removed request for a team July 19, 2024 14:10
@timothy-glover timothy-glover changed the title Fix UncertaintyReward bug and import ExpectedKLDivergence Fix UncertaintyReward bug and improve ExpectedKLDivergence Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (92dae99) to head (a6e0e46).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
- Coverage   94.19%   94.15%   -0.04%     
==========================================
  Files         207      207              
  Lines       13465    13467       +2     
  Branches     2740     2742       +2     
==========================================
- Hits        12683    12680       -3     
- Misses        530      532       +2     
- Partials      252      255       +3     
Flag Coverage Δ
integration 67.68% <100.00%> (-0.03%) ⬇️
unittests 90.21% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdhiscocks sdhiscocks added the bug label Jul 24, 2024
@sdhiscocks sdhiscocks merged commit 7644596 into dstl:main Jul 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants