Refactor YAML serialiser as ruamel.yaml plugin #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't be a breaking change, as original class simply proxied existing methods anyway. Also enable entry point to allow additional extensions to serialisation via entry point. This is to work over limitation of only being able to use one plugin at a time with ruamel.yaml, as well as allow easier integration with Stone Soup plugins.
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
==========================================
- Coverage 94.21% 94.11% -0.10%
==========================================
Files 143 143
Lines 7000 6984 -16
Branches 1031 1034 +3
==========================================
- Hits 6595 6573 -22
- Misses 308 312 +4
- Partials 97 99 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Not sure how to go about testing entry points part of this PR, but I can confirm I've tested locally, to ensure plugin aspect functions. |
sdhiscocks
requested review from
jswright-dstl and
idorrington-dstl
and removed request for
a team
oharrald-Dstl
approved these changes
Sep 22, 2021
idorrington-dstl
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be a breaking change, as original class simply proxied existing methods anyway.
Also enable entry point to allow additional extensions to serialisation via entry point. This is to work over limitation of only being able to use one plugin at a time with ruamel.yaml, as well as allow easier integration with Stone Soup plugins.