Add ChernoffUpdater class and track feeder #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekhunter123
requested review from
sdhiscocks and
jswright-dstl
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 94.59% 94.58% -0.01%
==========================================
Files 168 170 +2
Lines 8516 8557 +41
Branches 1652 1658 +6
==========================================
+ Hits 8056 8094 +38
- Misses 342 343 +1
- Partials 118 120 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Add Track feeder to feeder.rst Add Chernoff updater to updater.rst
jswright-dstl
approved these changes
Jul 28, 2022
sdhiscocks
requested changes
Jul 28, 2022
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Generalize the update and predicted measurement, rather than using the specific Gaussian state subclasses. Co-authored-by: Steven Hiscocks <sdhiscocks@dstl.gov.uk>
sdhiscocks
force-pushed
the
add_chernoff_updater
branch
from
136a794
to
ddeee1b
Compare
sdhiscocks
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the work done in the example in my latest pull request #666, we've made standalone classes for the
ChernoffUpdaterand theTracks2GaussianDetectionFeeder. I'd love any feedback or suggestions, thank you!Thanks to @sdhiscocks for the help in designing and writing these classes!
Sample usages of both these classes can be seen in the example #666 .