Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OptimizeBruteSensorManager #694

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Fix OptimizeBruteSensorManager #694

merged 4 commits into from
Aug 16, 2022

Conversation

nperree-dstl
Copy link
Contributor

@nperree-dstl nperree-dstl commented Aug 11, 2022

Small fix to OptimizeBruteSensorManager so that it uses the full capability of scipy.optimize.brute(). Also changes to tests to improve coverage.

@nperree-dstl nperree-dstl requested a review from a team as a code owner August 11, 2022 13:29
@nperree-dstl nperree-dstl requested review from sdhiscocks and removed request for a team August 11, 2022 13:29
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #694 (c1a71e7) into main (3d368a8) will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
+ Coverage   94.57%   94.59%   +0.01%     
==========================================
  Files         171      171              
  Lines        8615     8619       +4     
  Branches     1665     1666       +1     
==========================================
+ Hits         8148     8153       +5     
+ Misses        342      341       -1     
  Partials      125      125              
Flag Coverage Δ
integration 69.40% <33.33%> (-0.03%) ⬇️
unittests 92.13% <83.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stonesoup/sensormanager/optimise.py 94.91% <83.33%> (+2.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sdhiscocks sdhiscocks merged commit e7101f6 into main Aug 16, 2022
@sdhiscocks sdhiscocks deleted the optimised_SM_edits branch August 16, 2022 11:15
@sdhiscocks sdhiscocks added the bug label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants