Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move additional filter tutorials to subsection and fix binder post build script #704

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

sdhiscocks
Copy link
Member

binder build script was missing plotly dependency

@sdhiscocks sdhiscocks requested a review from a team as a code owner August 24, 2022 10:36
@sdhiscocks sdhiscocks requested review from nperree-dstl and orosoman-dstl and removed request for a team August 24, 2022 10:36
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #704 (dd80c45) into main (0418c1b) will not change coverage.
The diff coverage is n/a.

❗ Current head dd80c45 differs from pull request most recent head aaab1ee. Consider uploading reports for the commit aaab1ee to get more accurate results

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files         171      171           
  Lines        8794     8794           
  Branches     1707     1707           
=======================================
  Hits         8318     8318           
  Misses        344      344           
  Partials      132      132           
Flag Coverage Δ
integration 70.35% <ø> (+0.02%) ⬆️
unittests 90.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@nperree-dstl nperree-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! While we're at it can we add sphinx_gallery_thumbnail_number = 3 to the Information Filter tutorial so it's the same as the others?

@sdhiscocks sdhiscocks merged commit 380eb8f into main Aug 24, 2022
@sdhiscocks sdhiscocks deleted the tutorial_mods branch August 24, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants