Modify assign2D to exploit NumPy indexing #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdhiscocks
requested review from
nperree-dstl and
hpritchett-dstl
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #709 +/- ##
==========================================
- Coverage 94.62% 94.59% -0.04%
==========================================
Files 172 172
Lines 8845 8802 -43
Branches 1714 1698 -16
==========================================
- Hits 8370 8326 -44
- Misses 343 344 +1
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Previously this used iteration rather than indexing. By changing to using indexing, gives a performance benefit for large number of tracks/detections.
nperree-dstl
approved these changes
Sep 8, 2022
jswright-dstl
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this used iteration rather than indexing. By changing to using indexing and vectorising some calculations, gives a performance benefit for large number of tracks/detections.
Performance difference isn't noticeable on a small cost matrix, but testing on a
(1988, 4808)cost matrix results in identical output with ~50x to 60x speed up.