Maintain order of truths in tutorials for reproducibility #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to simulating detections in tutorials, the order of the truths, will change which random noise sample goes with each detections, centred on the truth. Maintaining order of truths should ensure that same random sample is used consistently. Fixes #718
sdhiscocks
requested review from
jswright-dstl and
nperree-dstl
and removed request for
a team
Codecov ReportBase: 94.81% // Head: 94.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 169 169
Lines 8221 8221
Branches 1216 1216
=======================================
Hits 7795 7795
Misses 316 316
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jswright-dstl
approved these changes
Oct 13, 2022
nperree-dstl
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to simulating detections in tutorials, the order of the truths, will change which random noise sample goes with each detections, centred on the truth. Maintaining order of truths should ensure that same random sample is used consistently.
Fixes #718