Add log weight property to Particle State #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may have performance advantage by simply storing weights in log space, and converting to weights dynamically when requried (utilising a cache for the property). Changes here are mostly backwards compatible, other than an issue with `from_state` method.
This handles the fact that the weight and particle list should be ignored for created states, as the elements of these are converted/stored in other parts of an instance, and only used during instantiation of the class.
sdhiscocks
requested review from
jswright-dstl and
mharris-dstl
and removed request for
a team
jswright-dstl
approved these changes
Apr 11, 2023
mharris-dstl
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a performance advantage with many particles, by simply storing weights in log space, and converting to weights dynamically when required (utilising a cache for the property).
Code changes include filters keeping weights in log space, and backwards compatible, so no need to make any changes to have performance advantage.
Relates to #780