Plot FOV on Sensor Management tutorials #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharris-dstl
reviewed
Jun 9, 2023
There was a problem hiding this comment.
Looks good, it's great to be able to see sensor management dynamically - I think it'll help new people understand what's going on.
I don't really mind either way but it could be worth putting the sensor fov into a function to save the code being written out twice, with a note saying not to worry about the contents of the function. I know that when I went through tutorials to start with, I tried to understand what each piece of code did, and would probably get bogged down by the code.
Having said that, it does the job well so I'm happy either way.
hpritchett-dstl
approved these changes
Jun 19, 2023
mharris-dstl
approved these changes
Jun 19, 2023
hpritchett-dstl
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sensor field of view to plot animations