Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of Bearing-only tracking #823

Merged
merged 45 commits into from
Nov 6, 2023
Merged

Conversation

A-acuto
Copy link
Contributor

@A-acuto A-acuto commented Jun 26, 2023

This PR present a simple example of single target simulation and tracking using Radar Bearing-Only measurements, following the detections of a moving platform.

This follows the style of other examples present in the tutorials and example sections.

@A-acuto A-acuto requested a review from a team as a code owner June 26, 2023 09:04
@A-acuto A-acuto requested review from jswright-dstl and rcgorman-dstl and removed request for a team June 26, 2023 09:04
Copy link
Contributor

@rcgorman-dstl rcgorman-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good example - made some minor corrections and fixed typos

docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
A-acuto and others added 11 commits July 3, 2023 10:09
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
@A-acuto
Copy link
Contributor Author

A-acuto commented Jul 3, 2023

Add more details in the introduction of the example, improved the text a bit and fixed the typos suggested.

Copy link
Contributor

@rcgorman-dstl rcgorman-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - minor corrections/suggestions made to finalise

docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
A-acuto and others added 2 commits July 3, 2023 17:53
Co-authored-by: rg <119332214+rcgorman-dstl@users.noreply.github.com>
Co-authored-by: rg <119332214+rcgorman-dstl@users.noreply.github.com>
Copy link
Contributor

@gawebb-dstl gawebb-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of optional suggestions but I'm happy for it to be merged in its current state

docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rcgorman-dstl rcgorman-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional changes look fine

docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
docs/examples/bearing_only_example.py Outdated Show resolved Hide resolved
A-acuto and others added 21 commits July 14, 2023 09:08
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
Co-authored-by: James Wright <69153443+jswright-dstl@users.noreply.github.com>
@A-acuto
Copy link
Contributor Author

A-acuto commented Aug 21, 2023

@jswright-dstl I have added the suggestions you proposed to this tutorial, do you want anything else changed or improved?

@sdhiscocks sdhiscocks merged commit 93d3b5e into dstl:main Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants