Error-Controller BRUF and Variable-Step BRUF #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass property. Added tests for VSBRUF.
…UF to inherit from BRUF. CHanges to BRUF methods to allow for inheritance. Fixed incorrect measurement_prediction calculations in tests.
…esianRecursiveUpdater. Tidy up of ECBRUF code
…veUpdater. Add tests for the ECBRUF updater.
spike-dstl
requested review from
sdhiscocks and
csherman-dstl
and removed request for
a team
sdhiscocks
reviewed
Jan 3, 2024
| @@ -699,3 +701,802 @@ def test_recursive_ensemble_errors(): | |||
| # Run updater | |||
| with pytest.raises(ValueError): | |||
| _ = updater.update(hypothesis) | |||
|
|
|||
|
|
|||
| def test_vsbruf_single_step(measurement_model, prediction, measurement, timestamp): | |||
There was a problem hiding this comment.
Is there a way to combine these tests using pytest.mark.parameterise instead of having many repeated tests with only a different updater?
sdhiscocks
approved these changes
Feb 12, 2024
Fix use_joseph_cov flag in VSBRUF test Co-authored-by: Christopher Sherman <146717651+csherman-dstl@users.noreply.github.com>
csherman-dstl
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an extension of PR #889. #889 will be closed as it is superseded by this.
New Updater classes:
Extensions of the BayesianRecursiveUpdater. Unlike how the BayesianRecursiveUpdater uses equal measurement noise for each recursive step, the VariableStepBayesianUpdater over-inflates measurement noise in the earlier steps, requiring the use of a smaller number of steps. The ErrorControllerBayesianRecursiveUpdater is a further extension in which error control parameters are introduced.