Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GOSPA metric to work with ParticleState #967

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

ollie-digi2al
Copy link

There was an issue converting a list of ParticleState objects into a numpy array. This pull request fixes this by replacing
np.array(measured_states)[meas_mask]

with

meas_points = np.empty(len(measured_states), dtype="O")
meas_points[:] = measured_states
meas_points = meas_points[meas_mask]

@ollie-digi2al ollie-digi2al requested a review from a team as a code owner March 14, 2024 12:07
@ollie-digi2al ollie-digi2al requested review from nperree-dstl and spike-dstl and removed request for a team March 14, 2024 12:07
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (10e26e0) to head (2503d26).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   93.52%   93.49%   -0.04%     
==========================================
  Files         201      201              
  Lines       12835    12837       +2     
  Branches     2629     2629              
==========================================
- Hits        12004    12002       -2     
- Misses        587      589       +2     
- Partials      244      246       +2     
Flag Coverage Δ
integration 66.26% <0.00%> (-0.02%) ⬇️
unittests 89.09% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdhiscocks sdhiscocks merged commit b90b598 into dstl:main Mar 15, 2024
10 checks passed
@ollie-digi2al ollie-digi2al deleted the fix_gospa_particle_state branch March 15, 2024 17:58
@sdhiscocks sdhiscocks added the bug label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants