Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real Literal::from_str from libproc_macro #296

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Use real Literal::from_str from libproc_macro #296

merged 1 commit into from
Aug 30, 2021

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Aug 30, 2021

Closes #287 now that rust-lang/rust#84717 has made it into a stable Rust release.

@alamb
Copy link

alamb commented Sep 9, 2021

FYI this broke a downstream project (apache/datafusion#961) when released, and looks like a few others as well (see the open issues linked)

Our fix was to pin to 1.0.28

@alamb
Copy link

alamb commented Sep 9, 2021

(thank you for all your work on the proc-macro2 crate, BTW -- we likely take much of this work for granted but it is appreciated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use proc_macro's impl FromStr for Literal once Rust 1.53 is stable
2 participants