Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support projects built with Babel 7 #13

Merged
merged 2 commits into from
May 21, 2019
Merged

Conversation

sltenorio99
Copy link
Contributor

@sltenorio99 sltenorio99 commented Feb 24, 2018

Fixes: #14
Should allow projects with Babel 7 to use babel-plugin-dva-hmr for the time being.

After an upgrade of a work project Babel 7, we experienced cannot read property 'file' of undefined errors because of this plugin. This commit fixes that and the plugin works as expected.

Later, a whole plugin transfer to Babel 7 could be implemented to keep up with the times.

@MayGo
Copy link

MayGo commented Sep 3, 2018

Any reason this is not merged?

@MayGo
Copy link

MayGo commented Sep 3, 2018

Thought, it would not work without this pull-request. But it works.

@vipcxj
Copy link

vipcxj commented Mar 13, 2019

@sorrycc Please merge it. It really solve the problem.

@dickeylth dickeylth mentioned this pull request May 21, 2019
@sorrycc sorrycc merged commit 26a8af3 into dvajs:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot read property 'file' of undefined errors when project uses Babel 7
4 participants