build: avoid always having workspaces=true

this is problematic when a workspace calls npm run as well as issues like actions/setup-node#712
dvirtz · Apr 8, 2024 · 5583342 · 5583342
1 parent ade699b
commit 5583342
Show file tree

Hide file tree

Showing 6 changed files with 13,662 additions and 1,568 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -27,6 +27,9 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 18
+          cache: npm
+        env:
+          npm_config_workspaces: false
       - uses: actions/setup-python@v5
         with:
           python-version: '3.10'
@@ -46,7 +49,7 @@ jobs:
         with:
           path: ${{ env.CONAN_HOME }}
           key: ${{ matrix.os }}-conan-${{ hashFiles('packages/parquet-reader/conanfile.txt') }}
-      - run: npm ci --foreground-scripts
+      - run: npm ci --forward-scripts
       - name: Static checks
         run: |
           npm run spellcheck
@@ -80,6 +83,9 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 18
+          cache: npm
+        env:
+          npm_config_workspaces: false
       - uses: actions/setup-python@v5
         with:
           python-version: '3.10'
@@ -92,13 +98,13 @@ jobs:
           path: packages/parquet-reader/prebuilds
           pattern: prebuilds-*
           merge-multiple: true
-      - run: npm ci
+      - run: npm ci --forward-scripts
       - name: Release
         env:
           GH_TOKEN: ${{ secrets.RELEASE_PAT }}
           VSCE_PAT: ${{ secrets.VSCE_PAT }}
           OVSX_PAT: ${{ secrets.OVSX_PAT }}
-        run: npx --no-workspaces semantic-release
+        run: npx semantic-release
       - name: Package
         if: github.ref != 'refs/heads/master'
         uses: lannonbr/vsce-action@master

diff --git a/.npmrc b/.npmrc
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -123,6 +123,21 @@
           "hidden": false,
         }
       },
+    },
+    {
+      "name": "Conan Install",
+      "type": "debugpy",
+      "request": "launch",
+      "module": "conans.conan",
+      "justMyCode": false,
+      "args": [
+        "install",
+        "${workspaceFolder}/packages/parquet-reader",
+        "-of=${workspaceFolder}/packages/parquet-reader/dist/build/conan",
+        "-pr=${workspaceFolder}/packages/parquet-reader/dist/build/conan_host_profile",
+        "--build=missing",
+        "-g CMakeDeps"
+      ]
     }
   ]
 }
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -3,14 +3,14 @@
   "tasks": [
     {
       "type": "npm",
-      "script": "clean",
+      "script": "clean --workspaces",
       "problemMatcher": [],
       "label": "npm: clean",
       "detail": "rimraf dist .vscode-test"
     },
     {
       "type": "npm",
-      "script": "build",
+      "script": "build --workspaces",
       "group": {
         "kind": "build",
         "isDefault": true