Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Fix patching and deploying issues #345

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[PR] Fix patching and deploying issues #345

merged 4 commits into from
Oct 19, 2023

Conversation

LuchoTurtle
Copy link
Member

@LuchoTurtle LuchoTurtle commented Oct 18, 2023

closes #344

This PR will also pave the way for #343 .

@LuchoTurtle LuchoTurtle added bug Suspected or confirmed bug (defect) in the code in-progress An issue or pull request that is being worked on by the assigned person labels Oct 18, 2023
@LuchoTurtle LuchoTurtle self-assigned this Oct 18, 2023
@LuchoTurtle
Copy link
Member Author

Going to temporarily enable deploying for PRs just to check if the patching fix works.

@LuchoTurtle
Copy link
Member Author

It works. Reverting..

@LuchoTurtle
Copy link
Member Author

I've made naming refactors to the workflows in preparation for #343.

Additionally, I've commented out the part deploying to fly.io. It's redundant, as we're actively using Github Pages for this.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #345 (81e57d5) into main (dd61af7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          24       24           
  Lines         447      447           
=======================================
  Hits          418      418           
  Misses         29       29           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Oct 18, 2023
@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 18, 2023
@LuchoTurtle LuchoTurtle marked this pull request as ready for review October 18, 2023 12:10
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuchoTurtle let's hope this works. 🙏

@nelsonic nelsonic merged commit 12022f5 into main Oct 19, 2023
3 checks passed
@nelsonic nelsonic deleted the fix_ci#344 branch October 19, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed bug Suspected or confirmed bug (defect) in the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Deploying to web is not working
2 participants