Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Release latest version of package with all dependencies updated #116 #117

Merged
merged 9 commits into from
Oct 20, 2022
Merged

PR: Release latest version of package with all dependencies updated #116 #117

merged 9 commits into from
Oct 20, 2022

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Oct 18, 2022 •
edited
Loading

This PR publishes a new version of the fields package to Hex.pm so that the latest version of the crypto is used in the downstream packages #116 hoping to fix dwyl/auth#231 ... 🤞

@nelsonic nelsonic added enhancement New feature or request in-progress labels Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Merging #117 (4d5db2b) into main (f7e8f3c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          128       129    +1     
=========================================
+ Hits           128       129    +1
Impacted Files Coverage Δ
lib/aes.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic
Copy link
Member Author

Sorry for all the random updates in the README.md ... VSCodium ... 🙄

@nelsonic
Copy link
Member Author

Package published to https://hex.pm/packages/fields/2.10.0 📦 🚀

@nelsonic
Copy link
Member Author

@SimonLab once you've had a chance to look at this PR (& merge) I will create a new release 👍

@nelsonic
Copy link
Member Author

Package published to https://hex.pm/packages/fields/2.10.1 📦 🤞
Testing now in auth ... dwyl/auth#231

@nelsonic nelsonic mentioned this pull request Oct 18, 2022
Closed
1 task
@nelsonic
Copy link
Member Author

Package published to https://hex.pm/packages/fields/2.10.2 📦 (3rd time lucky ...) 🍀
Testing in auth ... dwyl/auth#231 ⏳

@nelsonic
Copy link
Member Author

Package published to https://hex.pm/packages/fields/2.10.3 📦 ... OK this is getting a bit ridiculous!
Buuuuuuttt ... dwyl/auth#231 (comment) 🤦‍♂️

@nelsonic
Copy link
Member Author

OK. This is no longer the cause of our misery in Auth. So the PR can be merged. 👌

SimonLab
SimonLab approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@SimonLab SimonLab merged commit ae35a71 into main Oct 20, 2022
@SimonLab SimonLab deleted the release-latest-version-issue-#116 branch October 20, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review enhancement New feature or request
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab