Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tailwind CSS #121

Closed
4 tasks done
Tracked by #120
nelsonic opened this issue Nov 17, 2022 · 12 comments · Fixed by #120
Closed
4 tasks done
Tracked by #120

Add Tailwind CSS #121

nelsonic opened this issue Nov 17, 2022 · 12 comments · Fixed by #120
Assignees
Labels
chore enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed needs-ui A feature idea that needs UI in order to be discussed/built. priority-2 T1h technical

Comments

@nelsonic
Copy link
Member

nelsonic commented Nov 17, 2022

It's occurred to me that the CSS/Styles in this example are "meh" ...

image

And with the addition of Tailwind CSS in Phoenix 1.7 dwyl/learn-phoenix-framework#152
We can significantly improve the UI!

Luckily, we've already done the "hard" part in: dwyl/phoenix-liveview-chat-example#15-tailwind-css-stylin

liveview-chat-with-tailwind

So I expect that we can borrow much of the code from that tutorial
and estimate that it shouldn't take us more than T1h to get it done.
(probably much less Time/Effort, but being conservative for any layout issues ...)

Todo

@nelsonic nelsonic added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers T1h technical chore priority-2 needs-ui A feature idea that needs UI in order to be discussed/built. labels Nov 17, 2022
@nelsonic nelsonic self-assigned this Nov 17, 2022
nelsonic added a commit that referenced this issue Nov 17, 2022
nelsonic added a commit that referenced this issue Nov 17, 2022
@nelsonic
Copy link
Member Author

Included in: #120

@nelsonic nelsonic assigned LuchoTurtle and unassigned nelsonic Nov 17, 2022
@nelsonic
Copy link
Member Author

@LuchoTurtle this is pretty close to being done ...

image

I just don't have time to do the alignment of the inputs and buttons ...

image

Can you take a look when you finish your Flutter work? 💭

@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Nov 22, 2022
@nelsonic
Copy link
Member Author

@LuchoTurtle please include a screenshot of the finished thing in the issue before assigning it back to me.

@LuchoTurtle
Copy link
Member

LuchoTurtle commented Nov 22, 2022

Sorry about that.

It should look like this.

image

If the user is logged in, the username is shown. If the username is not available on the profile, it falls back to 'guest'.

image

@nelsonic
Copy link
Member Author

Sorry for not being clear.
The desired UI/UX is already in the OP.
This layout you've created certainly looks good. 👍
By all means add it to your Dribbble account: https://dribbble.com/tags/messaging
but it's over-thinking it by having the message box off to the right ... 🤷‍♂️
and doesn't look "mobile first" (i.e. "boring") ... 📱
Unless the mobile is a Tablet. 💭

I'm all for creating design variations and A-B testing them once we have a testing framework in place. 🆎
Until then we need to keep the designs as Boring (AF!) as possible even if it means that it "looks the same" as every other app that does something similar.

If even one non-technical person ever has to ask themself "Why is that there?"
or "Where is the ...?" then we have failed to build an intuitive interface.

I get that this way on a larger screen the person can see more of the message history. ✅
But you need to see this from perspective of the person who isn't used to seeing this layout
and doesn't see the immediate benefit and just thinks "Why...?" 🤷‍♂️

@nelsonic
Copy link
Member Author

For the avoidance of all future doubt: https://en.wikipedia.org/wiki/Occam's_razor

@LuchoTurtle LuchoTurtle assigned LuchoTurtle and unassigned nelsonic Nov 22, 2022
@LuchoTurtle
Copy link
Member

Changed it to look like so.
image

Waiting for a response on #120 (comment)
👀

@LuchoTurtle
Copy link
Member

#120 (comment)

Going to assign this for review, with the login issue resolved 👍

@nelsonic
Copy link
Member Author

Believe we can close this issue now as Tailwind is indeed in the PR we colab'd on: #120
Thanks again @LuchoTurtle 👌

@nelsonic
Copy link
Member Author

before:
image

@LuchoTurtle
Copy link
Member

Shouldn't this be open until #120 is merged?

@nelsonic
Copy link
Member Author

nelsonic commented Dec 1, 2022

Merged. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed needs-ui A feature idea that needs UI in order to be discussed/built. priority-2 T1h technical
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants