Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some quotes to the json file #63

Merged
merged 3 commits into from
Apr 12, 2022
Merged

add some quotes to the json file #63

merged 3 commits into from
Apr 12, 2022

Conversation

shaunpurslow
Copy link
Contributor

No description provided.

nelsonic
nelsonic previously approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaund16. 👍🏻
would be good to have source and tags for these. 💭

@shaunpurslow
Copy link
Contributor Author

Fixed!

@nelsonic nelsonic added help wanted Extra attention is needed merge-conflicts labels Apr 12, 2022
@nelsonic
Copy link
Member

I've attempted to fix the merge-conflicts in the quotes.json file.
But as noted in dwyl/learn-travis#67 Travis Builds aren't working.
I've done a manual check and the file appears to pass https://jsonlint.com/ as Valid JSON:

image

Happy to merge. 👍

@nelsonic nelsonic added awaiting-review and removed help wanted Extra attention is needed merge-conflicts labels Apr 12, 2022
@nelsonic nelsonic self-assigned this Apr 12, 2022
nelsonic
nelsonic approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaund16 thanks for adding these quotes. 👍
They don't strictly inspire action. 💭
But happy to merge them as you've made the effort to add them and they don't detract from the action-inspiring quotes.
Thanks again. ☀️

@nelsonic nelsonic merged commit cc2e951 into dwyl:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaunpurslow @nelsonic