Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badges issues #19 #20

Merged
merged 6 commits into from
Nov 12, 2021
Merged

Update badges issues #19 #20

merged 6 commits into from
Nov 12, 2021

Conversation

nelsonic
Copy link
Member

Quick one just to tidy up. #19

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #20 (f5dddac) into main (6db8dc6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files           1        1           
  Lines          46       46           
=======================================
  Hits           45       45           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db8dc6...f5dddac. Read the comment docs.

@nelsonic nelsonic mentioned this pull request Nov 12, 2021
3 tasks
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SimonLab SimonLab merged commit f3e8167 into main Nov 12, 2021
@SimonLab SimonLab deleted the update-badges-issues-#19 branch November 12, 2021 09:36
@@ -6,13 +6,13 @@ Role Based Access Control (**`RBAC`**) gives you
a human-friendly way of controlling access
to specific data/features in your App(s).

[![Build Status](https://img.shields.io/travis/com/dwyl/rbac/master.svg?style=flat-square)](https://travis-ci.com/dwyl/rbac)
[![Build Status](https://img.shields.io/travis/dwyl/rbac/master.svg?style=flat-square)](https://travis-ci.org/dwyl/rbac)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp! 🤦 I wasn't paying close enough attention last night. 😫

image

new PR for the build badge: #21

Copy link
Member

@SimonLab SimonLab Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry should have spotted that too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all. it was a subtle thing and that's why we have badges to inform us. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants