Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update to Hal Components #44

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Major update to Hal Components #44

merged 5 commits into from
Feb 17, 2023

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Feb 10, 2023

Summary of changes

  • Updated libraries:
    • @dxc-technology/halstack-react updated to 8.0.0.
    • @dxc-technology/halstack-react-client updated to 1.3.3.
  • Clean up the library's package.json.
  • Updated specs for the HalTable to match the current implementation and design of the DxcResultsetTable.
    • Updated the error font colour to match the DS error patterns and colour standards.
  • New Typescript implementation.
    • Now the Hal Components export types, which make them more secure when programming (type-checking, suggestions, comments, etc).
    • Updated build and configuration files to correctly export the typing.
    • /app example project has also been updated to use Typescript.
  • Updated README to match the new types and some typo fixes.
  • Majors:
    • HalAutocomplete prop url has been renamed to collectionUrl to match the rest of the hal components.

@GomezIvann GomezIvann marked this pull request as ready for review February 13, 2023 13:51
@GomezIvann GomezIvann linked an issue Feb 14, 2023 that may be closed by this pull request
lib/package.json Outdated Show resolved Hide resolved
@kukoc
Copy link
Contributor

kukoc commented Feb 15, 2023

The colors or the error fonts are different for the Table and the autocomplete. is there any reason for that?

kukoc
kukoc previously approved these changes Feb 15, 2023
@GomezIvann
Copy link
Collaborator Author

The colors or the error fonts are different for the Table and the autocomplete. is there any reason for that?

I decided to go for the error font colour because the HalTable had that text in a red colour previously, so to change the design as less as possible, I only updated that red colour to the new value in the CDK. In the case of the Text Input, that was a design decision made by Alex.

@jsuarezgonz jsuarezgonz merged commit d8219fc into master Feb 17, 2023
@raquelarrojo raquelarrojo deleted the gomezivann-hal-update branch July 26, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

halstack-react-hal support for latest halstack-react@7.0.0
3 participants