Return the connection string instead of the connection URL #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to construct relative URLs by appending strings instead of using the relative URL method, which doesn't work if the base URL is a URL as opposed to just a hostname. e-mission/e-mission-docs#732 (comment)
shankari
added a commit
to e-mission/e-mission-phone
that referenced
this pull request
May 29, 2022
This is a fix for the issue where the relative URL code on iOS doesn't work per documentation. Relative URL doesn't work: e-mission/e-mission-docs#732 (comment) Appending strings does work: e-mission/e-mission-docs#732 (comment) Includes fixes to: - connection settings to return a string instead of a URL e-mission/cordova-connection-settings#22 - server-communication and server-sync to concatenate directly using strings instead of using a relative URL e-mission/cordova-server-communication#30 e-mission/cordova-server-sync#52
shankari
added a commit
to e-mission/e-mission-devapp
that referenced
this pull request
May 30, 2022
This is a fix for the issue where the relative URL code on iOS doesn't work per documentation. Relative URL doesn't work: e-mission/e-mission-docs#732 (comment) Appending strings does work: e-mission/e-mission-docs#732 (comment) Includes fixes to: - connection settings to return a string instead of a URL e-mission/cordova-connection-settings#22 - server-communication and server-sync to concatenate directly using strings instead of using a relative URL e-mission/cordova-server-communication#30 e-mission/cordova-server-sync#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to construct relative URLs by appending strings
instead of using the relative URL method, which doesn't work if the base URL is
a URL as opposed to just a hostname.
e-mission/e-mission-docs#732 (comment)