Handle "other" modes without mappings in the JSON #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom footprint creation currently assumes that all modes have an CO2 entry in the JSON.
This is true, except in the case where the user selects "other" and puts in a custom mode.
In that case, we have no mapping, so the footprint map has an entry for {mode: undefined}
which causes the footprint calculations to return NaN.
We instead check whether we have a mapping and return `undefined` in that case.
We also filter out the undefined entries.
After this change, the custom other modes will be excluded, and we will use the
standard 0 - max footprint range to handle them.
The calorie/MET calculation already worked like this; so this just ensures that
both sets of values are consistent.
This fixes e-mission/e-mission-docs#697
|
Screenshot
|
shankari
added a commit
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom footprint creation currently assumes that all modes have an CO2 entry in the JSON.
This is true, except in the case where the user selects "other" and puts in a custom mode.
In that case, we have no mapping, so the footprint map has an entry for {mode: undefined}
which causes the footprint calculations to return NaN.
We instead check whether we have a mapping and return
undefinedin that case.We also filter out the undefined entries.
After this change, the custom other modes will be excluded, and we will use the
standard 0 - max footprint range to handle them.
The calorie/MET calculation already worked like this; so this just ensures that
both sets of values are consistent.
This fixes e-mission/e-mission-docs#697