Finish pending changes for the status screen #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most of these, we can translate the values directly since they are not platform specific. The fitness name is platform specific so we compute it in the controller, just like all the other names. This addresses beta testing feedback. "The wording of the movement permission and the unused apps permission were a bit different on my screen, and it took me a bit to figure out the unused apps permission. Perhaps the heading and instructions for those two permission items could be worded more closely to how they're each labeled in my two screenshots attached."
- Ask people to make everything green - Simplify the location permission Based on beta feedback e-mission/e-mission-docs#680 (comment)
…tration This is because if the notification is clicked when the app is not running, the pending clicks are delivered on `deviceready` when the app resumes. This apparently has issues with android. e-mission/e-mission-docs#680 (comment) e-mission/e-mission-docs#680 (comment) Using the changes suggested above, everything works e-mission/e-mission-docs#680 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can finally merge e-mission/e-mission-docs#680