Thin provisioning : Enable zero detecting for requests #349
Conversation
Add thin flag Add baseline functions for thin pro
shosseinimotlagh
force-pushed
the
thin_skip_all_zero
branch
2 times, most recently
from
41fe819
to
fd4cf35
Compare
| // all requests. The caller needs to load the requests before starting the job. The requests are loaded in the form of | ||
| // Write with three or four parameters and Read with three parameters. The value is optional and is used only for write | ||
| // requests. | ||
| class IOManualTestJob : public TestJob { |
There was a problem hiding this comment.
nit: Is there a reason why the existing IOTestJob::same_lbas() (with some modification) can't serve the purpose of this basic test?
Added a manual io job test
shosseinimotlagh
force-pushed
the
thin_skip_all_zero
branch
from
fd4cf35
to
2770a52
Compare
| // Case one: normal read (no zero padding) | ||
| std::make_tuple("write", 0, 100, 4), std::make_tuple("read", 5, 20), | ||
| // Case two: zero padding, read after write | ||
| std::make_tuple("write", 1, 10), std::make_tuple("read", 1, 20), std::make_tuple("read", 5, 3), |
There was a problem hiding this comment.
1- write zeros from lba 1 to 10
2- read a) from lba 1 to 20 b) from lba 5 to lba 7
There was a problem hiding this comment.
What I meant is to put some comment in the code for readers to understand better.
Questinon: how come "read", 5, 3 maps to read from lba 5 to 7?
| // Case two: zero padding, read after write | ||
| std::make_tuple("write", 1, 10), std::make_tuple("read", 1, 20), std::make_tuple("read", 5, 3), | ||
| // Case three: zero padding, overlapping for read | ||
| std::make_tuple("write", 100, 200), std::make_tuple("read", 150, 250), |
There was a problem hiding this comment.
1- write zeros from lba 100 to 200
2- read from lba 150 to 350 - half a portion is populated with zero buffers
| // Case three: zero padding, overlapping for read | ||
| std::make_tuple("write", 100, 200), std::make_tuple("read", 150, 250), | ||
| // Case four: no write | ||
| std::make_tuple("read", 800, 5)}; |
There was a problem hiding this comment.
read from lbas that have been not populated.
|
Please make sure all github CI is passing before merge. Thanks. |
shosseinimotlagh
merged commit ed3ffae
into
eBay:thin_provisioning
No description provided.