Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutdown raft services before grpc server #100

Closed
wants to merge 1 commit into from
Closed

shutdown raft services before grpc server #100

wants to merge 1 commit into from

Conversation

raakella1
Copy link
Contributor

No description provided.

@szmyd
Copy link
Collaborator

szmyd commented Sep 9, 2024

Do we need this in stable/v6.x as well? Can we merge it there first if so and bubble it up to main?

@raakella1
Copy link
Contributor Author

Do we need this in stable/v6.x as well? Can we merge it there first if so and bubble it up to main?

Yes, we do. I think we do not see it in nublox is raft is not in use when shutdown happens. Lemmi open a PR in stable first

@raakella1 raakella1 closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxichen xiaoxichen Awaiting requested review from xiaoxichen

@szmyd szmyd Awaiting requested review from szmyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raakella1 @szmyd