Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make optional.hpp readable by SWIG [19674] #169

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Make optional.hpp readable by SWIG [19674] #169

merged 1 commit into from
Oct 17, 2023

Conversation

richiware
Copy link
Member

No description provided.

@richiware
Refs #19659. Separate optional header in two
712dc75 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware richiware changed the title Make optional.hpp readable by SWIG Make optional.hpp readable by SWIG [19674] Oct 6, 2023
This was referenced Oct 6, 2023
Merged
Merged
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

JLBuenoLopez
JLBuenoLopez approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JLBuenoLopez
Copy link
Contributor

A successful CI run can be found here

@richiware richiware merged commit 7112895 into master Oct 17, 2023
9 of 10 checks passed
@richiware richiware deleted the bugfix/swig branch October 17, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @richiprosima @JLBuenoLopez